KEP-2906: Update Catalog schema for CRD compatibility

[KnVerey]

• One-line PR description: Small update to the schema for function definitions to be compatible with CRD by ensuring that where they have the same fields, they are in the same places.

• Issue link: Kustomize KRM Plugin Catalog #2906

• Comments: See fn framework: Enable validation using openAPI schema for functionConfig kubernetes-sigs/kustomize#4467 for an example use case. This really only required one change, i.e. spec.kind -> spec.names.kind. Here's the CRD reference, for reference. I also updated the type name for clarity (it's the CRD equivalent, not the CR). The rest of the updates are fixing examples that didn't match the schema even as it was before this PR.

/cc @mengqiy @jeremyrickard

[jeremyrickard]

I think this looks good. I approve, but I'll drop a hold because I think my approval will auto merge it based on my enhancements role. And other reviewer, if you approve feel free to drop the hold

/lgtm

/hold for others to review

[natasha41575]

We need to make the same changes to https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2985-public-krm-functions-registry, right? It leverages the KRMFunction definition from here.

[mengqiy]

We will need to update it if we change the name here.

[KnVerey]

Good call--the names.kind change needs to be made there as well.

[mengqiy]

Why do we want to change the name here?

[KnVerey]

As part of strengthening the analogy to CRD, I though it would be useful to include "Definition" in the name of this type. In the same way that the CRD kind defines a CR rather than being one itself, this type defines a function. Does that make sense?

[mengqiy]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/sig-cli/OWNERS [KnVerey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KnVerey]

/unhold