Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1591: Promote DS maxSurge to GA #3307

Merged
merged 1 commit into from
Jun 10, 2022
Merged

KEP-1591: Promote DS maxSurge to GA #3307

merged 1 commit into from
Jun 10, 2022

Conversation

ravisantoshgudimetla
Copy link
Contributor

  • One-line PR description:
    Promote DS maxSurge to GA
  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 10, 2022
@k8s-ci-robot k8s-ci-robot requested review from kow3ns and soltysh May 10, 2022 18:52
@kikisdeliveryservice kikisdeliveryservice changed the title Promote DS maxSurge to GA KEP-1591: Promote DS maxSurge to GA May 13, 2022
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented May 13, 2022 •
edited
Loading

As a small reminder, we have updated our KEP template Test Plan section. This enhancement is using the previous version. Please be sure to update relevant sections for acceptance into the release. :)

kikisdeliveryservice
kikisdeliveryservice reviewed May 13, 2022
View reviewed changes
keps/prod-readiness/sig-apps/1591.yaml Outdated
@@ -3,3 +3,5 @@ alpha:
approver: "@deads2k"
beta:
approver: "@ehashman"
stable:
approver: "@ehashman"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik, she isn't reviewing PRR in 1.25

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - feel free to switch to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2022
@wojtek-t wojtek-t self-assigned this Jun 7, 2022
@wojtek-t
Copy link
Member

wojtek-t commented Jun 8, 2022

Please get the SIG approval and I will take a look at it then.

soltysh
soltysh reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravisantoshgudimetla a couple of comments

keps/sig-apps/1591-daemonset-surge/README.md Outdated

##### Integration tests

We've enough coverage in the unit and e2e tests. No new integration tests are added
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd encourage to add that integration, something similar to https://github.com/kubernetes/kubernetes/blob/cfda5bc1d8f07c422c174c68ebf5d27385525570/test/integration/deployment/deployment_test.go#L114-L206

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also:

For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
https://storage.googleapis.com/k8s-triage/index.html

from the template.

keps/sig-apps/1591-daemonset-surge/README.md Show resolved Hide resolved
keps/sig-apps/1591-daemonset-surge/README.md Outdated

##### e2e tests

An e2e test which exercises maxSurge when surge is used as update strategy is added for daemonsets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new or existing, also from the template:

For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
https://storage.googleapis.com/k8s-triage/index.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added it in the alpha stage itself. I've updated the test link

keps/sig-apps/1591-daemonset-surge/kep.yaml Show resolved Hide resolved
wojtek-t
wojtek-t reviewed Jun 9, 2022
View reviewed changes
keps/sig-apps/1591-daemonset-surge/README.md Outdated
```
##### Integration tests

Will add a new integration test to test the daemonSet upgrade/downgrade strategies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more specific about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the wording. PTAL.

keps/sig-apps/1591-daemonset-surge/README.md Outdated

An e2e test which exercises maxSurge when surge is used as update strategy is added for daemonsets.

- should surge pods onto nodes when spec was updated and update strategy is RollingUpdate: [test grid](https://testgrid.k8s.io/sig-apps#gce-serial)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the traige page:

https://storage.googleapis.com/k8s-triage/index.html

so that we can easily assess its flakiness

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changed it to https://storage.googleapis.com/k8s-triage/index.html?test=should%20surge%20pods

keps/sig-apps/1591-daemonset-surge/README.md Outdated

An e2e test which exercises maxSurge when surge is used as update strategy is added for daemonsets.

- should surge pods onto nodes when spec was updated and update strategy is RollingUpdate: [test grid](https://testgrid.k8s.io/sig-apps#gce-serial)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the traige page:

https://storage.googleapis.com/k8s-triage/index.html

so that we can easily assess its flakiness

keps/sig-apps/1591-daemonset-surge/README.md Show resolved Hide resolved
keps/sig-apps/1591-daemonset-surge/README.md Show resolved Hide resolved
@marosset marosset mentioned this pull request Jun 9, 2022
Closed
@wojtek-t
Copy link
Member

/approve PRR

soltysh
soltysh approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6f0d395 into kubernetes:master Jun 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@soltysh soltysh mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice left review comments

@soltysh soltysh soltysh approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@soltysh soltysh

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@ravisantoshgudimetla @kikisdeliveryservice @wojtek-t @k8s-ci-robot @soltysh