Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3178: rename feature gate to IPTablesOwnershipCleanup #3444

Merged
merged 1 commit into from
Jul 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions keps/sig-network/3178-iptables-cleanup/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ because it is more of a cleanup/bugfix than a new feature.) We should
also ensure that kpng gets updated.

Kubelet's behavior will not change by default, but if you enable the
`IPTablesCleanup` feature gate, then:
`IPTablesOwnershipCleanup` feature gate, then:

1. It will stop creating `KUBE-MARK-DROP`, `KUBE-MARK-MASQ`,
`KUBE-POSTROUTING`, and `KUBE-KUBELET-CANARY`. (`KUBE-FIREWALL`
Expand Down Expand Up @@ -518,7 +518,7 @@ This section must be completed when targeting alpha to a release.
###### How can this feature be enabled / disabled in a live cluster?

- [X] Feature gate (also fill in valuesin `kep.yaml`)
- Feature gate name: IPTablesCleanup
- Feature gate name: IPTablesOwnershipCleanup
- Components depending on the feature gate:
- kubelet

Expand Down Expand Up @@ -684,6 +684,7 @@ Major milestones might include:

- Initial proposal: 2022-01-23
- Updated: 2022-03-27, 2022-04-29
- Updated: 2022-07-26 (feature gate rename)

## Drawbacks

Expand Down
2 changes: 1 addition & 1 deletion keps/sig-network/3178-iptables-cleanup/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ milestone:
# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
feature-gates:
- name: IPTablesCleanup
- name: IPTablesOwnershipCleanup
components:
- kubelet
disable-supported: true
Expand Down