Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3017: rewrite PodHealthyPolicy KEP into UnhealthyPodEvictionPolicy #3677

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

atiratree
Copy link
Member

  • One-line PR description: changes to reflect the implementation that was considerably altered as compared to this KEP
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2022
@k8s-ci-robot k8s-ci-robot requested a review from kow3ns December 8, 2022 00:12
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Dec 8, 2022
@k8s-ci-robot k8s-ci-robot requested a review from soltysh December 8, 2022 00:12
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2022
@atiratree atiratree force-pushed the update-healthy-policy branch from 659e930 to 612c538 Compare December 8, 2022 00:30
@atiratree
Copy link
Member Author

/assign @liggitt
/assign @soltysh

@liggitt
Copy link
Member

liggitt commented Dec 8, 2022

content changes lgtm, I would actually keep the directory name the same and avoid renaming the files and losing history

@atiratree atiratree force-pushed the update-healthy-policy branch from 612c538 to ecbac28 Compare December 9, 2022 17:25
@atiratree
Copy link
Member Author

+1, I have removed the rename and keeping the old name 3017-pod-healthy-policy-for-pdb, a bit inconsitent but pragmatic as all the old links will keep working

Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. Thanks for making these changes @atiratree

@liggitt
Copy link
Member

liggitt commented Dec 12, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve


Currently, we only allow evicting Running pods in case there are enough pods healthy
(`.status.currentHealthy` is at least equal to `.status.DesiredHealthy`).
This is to give the application best change to achieve availability and prevent data loss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is to give the application best change to achieve availability and prevent data loss
This is to give the application best chance to achieve availability and prevent data loss

// Clients making eviction decisions should disallow eviction of unhealthy pods
// if they encounter an unrecognized policy in this field.
//
// This field is alpha-level. The eviction API uses this field when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: when updating this for beta, I'd just drop this information, it's important to be in the API, but not so in enhancement, and you'll have to remember to update it every time 😉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, liggitt, ravisantoshgudimetla, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit a6c6eb2 into kubernetes:master Dec 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 20, 2022
@atiratree
Copy link
Member Author

@soltysh created a followup for the nits: #3701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants