Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3017: make API definition of UnhealthyPodEvictionPolicy unversioned #3701

Merged
merged 1 commit into from
Dec 22, 2022
Merged

KEP-3017: make API definition of UnhealthyPodEvictionPolicy unversioned #3701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions keps/sig-apps/3017-pod-healthy-policy-for-pdb/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ and thus should be evicted without being potentially constrained by a Pod Disrup

Currently, we only allow evicting Running pods in case there are enough pods healthy
(`.status.currentHealthy` is at least equal to `.status.DesiredHealthy`).
This is to give the application best change to achieve availability and prevent data loss
This is to give the application best chance to achieve availability and prevent data loss
by disallowing disruption of starting pods that have not become Healthy (Ready yet).

We also want to allow unconditional eviction of Running pods for applications that do not have
Expand Down Expand Up @@ -165,10 +165,6 @@ type PodDisruptionBudgetSpec struct {
// Additional policies may be added in the future.
// Clients making eviction decisions should disallow eviction of unhealthy pods
// if they encounter an unrecognized policy in this field.
//
// This field is alpha-level. The eviction API uses this field when
// the feature gate PDBUnhealthyPodEvictionPolicy is enabled (disabled by default).
// +optional
UnhealthyPodEvictionPolicy *UnhealthyPodEvictionPolicyType `json:"unhealthyPodEvictionPolicy,omitempty" protobuf:"bytes,4,opt,name=unhealthyPodEvictionPolicy"`
}

Expand Down