Skip to content

Conversation

@jensentanlo
Copy link
Contributor

Add New Indexed Job backoff limit mode that is counted per index rather than per job, allowing all indices to run to completion

Issue Link: kubernetes/kubernetes#109712
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 23, 2023

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jensentanlo!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jensentanlo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jensentanlo
Once this PR has been reviewed and has the lgtm label, please assign kow3ns for approval by writing /assign @kow3ns in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 23, 2023
@kannon92
Copy link
Contributor

kannon92 commented Feb 7, 2023

Other comments: I couldn't figure out which number to assign for this KEP so I left it blank for the moment

From my understanding you create an issue in the Kubernetes Enhancement repo and use that issue number as the KEP number.

Also don't forget to sign the CLA.

indexed jobs were used as the basis for a suite of long-running integration tests,
then each test run would only be able to find a single test failure.

More generally, this use case is for any situation when all the indices in an indexed job
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this comment to be a bit confusing. You mention above that the implementation does not cover the situation where the workload is truly embarrassingly parallel.

But then you also mention that the use case is for when all indices are independent. I always thought that was what embarrassingly parallel meant all the cases were independent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback, I absolutely agree that it's confusing. I meant that the current implementation does not cover the use case when all indices are independent/embarassingly parallel, and that this KEP would cover it.

I've pushed a revised version that hopefully clears it up

@soltysh
Copy link
Contributor

soltysh commented Feb 7, 2023

@jensentanlo I'd also suggest bringing this topic to sig-apps meeting before submitting a KEP, to present the idea, and get feedback from the sig about the direction and feasibility

@alculquicondor
Copy link
Member

/cc

@jensentanlo
Copy link
Contributor Author

@jensentanlo I'd also suggest bringing this topic to sig-apps meeting before submitting a KEP, to present the idea, and get feedback from the sig about the direction and feasibility

Hi soltysh, I've been discussing this on-and-off for a while with some members of sig-apps on this Github issue: kubernetes/kubernetes#109712

I'd be happy to bring it to a sig-apps meetings if that would be helpful; what's the procedure to get on the agenda?

@soltysh
Copy link
Contributor

soltysh commented Feb 8, 2023

I'd be happy to bring it to a sig-apps meetings if that would be helpful; what's the procedure to get on the agenda?

Just add your topic with your name/github handle to our agenda for the next one, which will be Feb 20th. The meetings are open to everyone to join and discuss these topics in a more interactive form 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants