Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote ServiceNodePortStaticSubrange to beta #3985

Merged
merged 1 commit into from
May 8, 2023
Merged

promote ServiceNodePortStaticSubrange to beta #3985

merged 1 commit into from
May 8, 2023

Conversation

xuzhenglun
Copy link
Contributor

  • One-line PR description: KEP-3668: promote to beta
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from shaneutt May 5, 2023 05:32
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin May 5, 2023 05:32
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 5, 2023
@xuzhenglun xuzhenglun mentioned this pull request May 5, 2023
Closed
16 tasks
@aojea
Copy link
Member

aojea commented May 5, 2023

/lgtm
/approve

/assign @wojtek-t @thockin

criteria is no issues reported, and there was no issue AFAIK

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
thockin
thockin reviewed May 5, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@wojtek-t
Copy link
Member

wojtek-t commented May 8, 2023

/lgtm
/approve PRR

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin, wojtek-t, xuzhenglun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit b999024 into kubernetes:master May 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@thockin thockin

@aojea aojea

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
5 participants
@xuzhenglun @aojea @wojtek-t @k8s-ci-robot @thockin