Add known failure mode for Server Side Apply #4308

mimowo · 2023-10-20T10:53:44Z

One-line PR description: documenting the known failure mode behind for better visibility of potential SSA users: Pod Garbage collector fails to clean up PODs from nodes that are not running anymore kubernetes#118261.

Issue link: Server-side Apply #555

Other comments:
The issue for PodGC is fixed by withdrawing from SSA in core k8s components, but the issue remains and is tracked under ContainerPorts SSA key is insufficiently unique - SSA fails with "duplicate" error when the contents are valid kubernetes#113482

k8s-ci-robot · 2023-10-20T10:53:58Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mimowo
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

keps/sig-api-machinery/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mimowo · 2023-10-20T10:54:33Z

/assign @liggitt
FYI @apelisse @alculquicondor

liggitt · 2023-10-20T13:40:03Z

keps/sig-api-machinery/555-server-side-apply/README.md

+      container pods are not created. Also, update the existing pods to cleanup
+      the problematic fields.
+    - Testing: [PodGC integration test](https://github.com/kubernetes/kubernetes/blob/7b9d244efd19f0d4cce4f46d1f34a6c7cff97b18/test/integration/podgc/podgc_test.go#L313)
+      reproduced the issue before withdrawing from SSA in PodGC in the [PR #121103](https://github.com/kubernetes/kubernetes/pull/121103).


the fix for this is in flight in kubernetes-sigs/structured-merge-diff#253, I don't think updating the design doc for this is helpful... the github issues mentioned seem sufficient, especially once the SSA impact is fixed

I wasn't aware of the ongoing fix.

Still, it might be worth it to inform users, who might be using older versions somehow, and the section "known failure modes" seems the valid place. However, if there is consensus this is not the right place, then I'm happy to close the PR.

I think the "known failure modes" are about failure modes inherent in the design, but will defer to @apelisse if he thinks it's useful to include this here

I think this more of a decision of a PRR reviewer. What's your stance @wojtek-t?

I think it might be useful to include it here, but since the fix is very close to land, I would wait to see how we manage to backport it and stuff before updating since we will have to update again soon anyways.

I would personally merge it, but requires SIG lead approval.

@soltysh - can you please approve?

I would personally merge it, but requires SIG lead approval.

@soltysh - can you please approve?

This one falls under api-machinery so @deads2k, @jpbetz or @fedebongio

Chasing the structured-merge-diff failure, it appears to have merged into kube in kubernetes/kubernetes#121575. Is this "SSA doesn't work under these conditions" still valid?

IIUC the generic issue remains open: kubernetes/kubernetes#113482
However, the kubernetes/kubernetes#121575 PR fixes the use-case we had for pod disruption conditions, where subresource is patched. So using SSA for status is fixed, but not in general.

I have queued at item in the apimachinery agenda for "sometime after kep freeze": https://docs.google.com/document/d/1x9RNaaysyO0gXHIr1y50QFbiL1x8OWnk2v3XnrdkT5Y/edit

k8s-triage-robot · 2024-01-22T15:32:55Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

wojtek-t · 2024-02-07T10:33:58Z

/lgtm

soltysh · 2024-02-07T11:51:04Z

/label tide/merge-method-squash

mimowo · 2024-02-10T11:50:51Z

/reopen
Closed by mistake during my local cleanup

k8s-ci-robot · 2024-02-10T11:50:56Z

@mimowo: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-03-11T12:15:59Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-04-10T12:29:04Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-04-10T12:29:10Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2023

k8s-ci-robot requested review from fedebongio and jpbetz October 20, 2023 10:53

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023

k8s-ci-robot assigned liggitt Oct 20, 2023

mimowo mentioned this pull request Oct 20, 2023

Server-side Apply #555

Closed

mimowo force-pushed the ssa-known-failure-mode branch 3 times, most recently from 7f92989 to 81786ee Compare October 20, 2023 11:35

liggitt reviewed Oct 20, 2023

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024

mimowo added 2 commits January 23, 2024 12:13

Add known failure mode for Server Side Apply

a281c68

add a note that it only refers to the status

2c4e073

mimowo force-pushed the ssa-known-failure-mode branch from 81786ee to 2c4e073 Compare January 23, 2024 11:22

k8s-ci-robot assigned wojtek-t Feb 7, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 7, 2024

mimowo closed this Feb 10, 2024

mimowo deleted the ssa-known-failure-mode branch February 10, 2024 11:49

mimowo restored the ssa-known-failure-mode branch February 10, 2024 11:50

k8s-ci-robot reopened this Feb 10, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2024

k8s-ci-robot closed this Apr 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add known failure mode for Server Side Apply #4308

Add known failure mode for Server Side Apply #4308

mimowo commented Oct 20, 2023

k8s-ci-robot commented Oct 20, 2023

mimowo commented Oct 20, 2023

liggitt Oct 20, 2023

mimowo Oct 20, 2023 •

edited

Loading

liggitt Oct 20, 2023

alculquicondor Oct 20, 2023

apelisse Oct 20, 2023

wojtek-t Feb 7, 2024

soltysh Feb 7, 2024

deads2k Feb 7, 2024

mimowo Feb 7, 2024 •

edited

Loading

deads2k Feb 7, 2024

k8s-triage-robot commented Jan 22, 2024

wojtek-t commented Feb 7, 2024

soltysh commented Feb 7, 2024

mimowo commented Feb 10, 2024 •

edited

Loading

k8s-ci-robot commented Feb 10, 2024

k8s-triage-robot commented Mar 11, 2024

k8s-triage-robot commented Apr 10, 2024

k8s-ci-robot commented Apr 10, 2024

Add known failure mode for Server Side Apply #4308

Add known failure mode for Server Side Apply #4308

Conversation

mimowo commented Oct 20, 2023

k8s-ci-robot commented Oct 20, 2023

mimowo commented Oct 20, 2023

Choose a reason for hiding this comment

mimowo Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mimowo Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-triage-robot commented Jan 22, 2024

wojtek-t commented Feb 7, 2024

soltysh commented Feb 7, 2024

mimowo commented Feb 10, 2024 • edited Loading

k8s-ci-robot commented Feb 10, 2024

k8s-triage-robot commented Mar 11, 2024

k8s-triage-robot commented Apr 10, 2024

k8s-ci-robot commented Apr 10, 2024

mimowo Oct 20, 2023 •

edited

Loading

mimowo Feb 7, 2024 •

edited

Loading

mimowo commented Feb 10, 2024 •

edited

Loading