Skip to content

Conversation

@MikeSpreitzer
Copy link
Member

@MikeSpreitzer MikeSpreitzer commented Jan 22, 2024

  • One-line PR description:
    This PR updates the kep.yaml to mark it as implemented, and sets latest-milestone to 1.30 because we are changing the storage version and widening a validation criterion in 1.30.
  • Other comments:

Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024
@MikeSpreitzer
Copy link
Member Author

/cc @deads2k

@k8s-ci-robot k8s-ci-robot requested a review from deads2k January 22, 2024 20:03
@deads2k
Copy link
Contributor

deads2k commented Jan 22, 2024

storage change is expected. Less familiar with the validation change.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@MikeSpreitzer
Copy link
Member Author

The validation change is kubernetes/kubernetes#121510

@k8s-ci-robot k8s-ci-robot merged commit 5031ced into kubernetes:master Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 22, 2024
@MikeSpreitzer MikeSpreitzer deleted the apf-implemented branch January 22, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants