KEP 1645: clarify the chosen conflict resolution algorithm #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MrFreezeex
commented
Jun 2, 2024
MrFreezeex
commented
- One-line PR description: This PR attempt to explain the reasons why the resolution algorithm was chosen by considering other conflict resolution algorithm in the alternatives sections and explaining why those were not selected.
- Issue link: Multi-Cluster Services API #1645
- Other comments: I tried to consider some other approaches based on what was discussed on the sig-multicluster meeting the 2024/04/30. However as this decision was made several years ago and I tried to fill the gap and imagine the reasons why those alternatives approach were not chosen, those reasons could not fully reflect what was brought up during this KEP original design. So if you remember some other reasons from that time (or any other reasons why we would not want to chose those) feel free to chime in!
This PR attempt to explain the reasons why the resolution algorithm was chosen by considering other conflict resolution algorithm in the alternatives sections and explaining why those were not selected. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
k8s-ci-robot
added
kind/kep
k8s-ci-robot
added
sig/multicluster
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
@JeremyOT for multi-cluster approval? |
|
/approve Thanks @MrFreezeex! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, skitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.