-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3695: Update podResourceV1 API #4913
Conversation
ArangoGutierrez
commented
Oct 9, 2024
- One-line PR description: Update KEP 3695 to reflect current implementation
- Issue link: KEP-3695
- Other comments: as per the discussion on DRA: Extend PodResources to include resources from Dynamic Resource Allocation #3695 I have removed all references to Networking to focus solely on the Node elements for this KEP.
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
/cc @aojea |
/lgtm perfect, thank you very much, appreciate the prompt response |
/approve @mrunalp for final approval |
/assign @derekwaynecarr |
@@ -200,8 +208,8 @@ message CDIDevice { | |||
|
|||
// GetPodResourcesRequest contains information about the pod | |||
message GetPodResourcesRequest { | |||
string name = 1; | |||
string namespace = 2; | |||
string pod_name = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a major breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already merged code, I am just updating the KEP to the existing code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @mrunalp /lgtm |
Just to clarify: this is just cleanup and not a implementation for this feature in 1.32? Or do we want some development time/reviewers for this feature for 1.32? |
No updates expected for this release in terms of code -- this was just a "cleanup" effort to bring the KEP in line with the current code and remove all references in the text saying that these extensions are intended for networking plugins. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, klueska, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |