KEP-2837: Beta Graduation Criteria for 1.34 #5362

ndixita · 2025-06-03T03:07:01Z

One-line PR description: Update details around alignment managers, autoscalers

Issue link: Pod level resources #2837

Other comments: For Beta, following features are in scope:
- eviction manager
- events associated with topology, memory and cpu manager to bubble up unsupported alignment operations for guaranteed pods with pod level resources
- implementation details around HPA, VPA and cluster autoscaler
- moved in place pod level resources resize to Adding Alpha criteria for KEP to support IPPR & Pod Level Resources #5423
- full support for alignment managers moved to future work
- support for windows moved to future work
- advanced vpa algorithm to recommend proportionate pod limits with container limits moved to future work and subject to further discussions

k8s-ci-robot · 2025-06-03T03:07:03Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

pravk03

If a user attempts to configure scope=container for such a pod

Topology Manager scope (container/pod) is a node level setting.

keps/sig-node/2837-pod-level-resource-spec/README.md

ndixita · 2025-06-12T17:09:37Z

/sig autoscaling

ndixita · 2025-06-12T17:14:10Z

/assign @tallclair

keps/sig-node/2837-pod-level-resource-spec/README.md

mrunalp · 2025-06-18T23:29:06Z

Can we summarize in the description and/or the commit message the proposed changes (some are lost in the discussion threads)?

tallclair · 2025-06-18T23:29:37Z

/lgtm

soltysh

The 3 PRR questions (tests for enablement/disablement, upgrade->downgrade->upgrade and new fields estimation) are the remaining blocking items.

keps/sig-node/2837-pod-level-resource-spec/kep.yaml

soltysh · 2025-06-19T08:44:18Z

keps/sig-node/2837-pod-level-resource-spec/README.md

+  - [VPA](#vpa-1)
 <!-- /toc -->




Please make sure to include the second one in the release, it's currently missing lead-opted-in label and milestone set. This needs to be done by sig-node leads.

keps/sig-node/2837-pod-level-resource-spec/README.md

soltysh · 2025-06-19T09:01:21Z

keps/sig-node/2837-pod-level-resource-spec/README.md

+* Resource Allocation Managers i.e. Topology, Memory and CPU managers support with
+  Pod-level resources is past alpha.

 ### Upgrade / Downgrade Strategy


In ###### Are there any tests for feature enablement/disablement? you're describing tests that were planned for alpha, can you add there links to those tests?

###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested? is missing answers, it currently mentions only that it will be tested? Was it? Can you describe the steps?

In ###### Will enabling / using this feature result in increasing size or count of the existing API objects? you're missing estimated size increase, and amount of new objects (see comments above that section)

Addressed the concerns.

raywainman

LGTM for SIG-Autoscaling

keps/sig-node/2837-pod-level-resource-spec/README.md

@sanposhiho

@sanposhiho lgmt'd PR after @ndixita resolved the review feedback

Signed-off-by: ndixita <ndixita@google.com>

jackfrancis · 2025-06-19T17:50:52Z

/lgtm
/approve

jackfrancis · 2025-06-19T18:48:48Z

/assign @soltysh @deads2k

soltysh

/approve
the PRR section

k8s-ci-robot · 2025-06-19T20:01:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mrunalp, ndixita, sanposhiho, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/prod-readiness/OWNERS~~ [soltysh]
~~keps/sig-node/OWNERS~~ [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2025

k8s-ci-robot requested review from derekwaynecarr and mrunalp June 3, 2025 03:07

pravk03 reviewed Jun 3, 2025

View reviewed changes

ndixita force-pushed the pod-level-resources-beta branch 3 times, most recently from 3da0389 to 471221b Compare June 11, 2025 23:04

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025

ndixita marked this pull request as ready for review June 11, 2025 23:10

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2025

k8s-ci-robot requested a review from palnabarun June 11, 2025 23:10

This was referenced Jun 11, 2025

KEP-2837: update latest milestone for v1.34 #5403

Closed

Pod level resources #2837

Open

adrianmoisey reviewed Jun 12, 2025

View reviewed changes

keps/sig-node/2837-pod-level-resource-spec/README.md Outdated Show resolved Hide resolved

adrianmoisey reviewed Jun 12, 2025

View reviewed changes

keps/sig-node/2837-pod-level-resource-spec/README.md Outdated Show resolved Hide resolved

k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Jun 12, 2025

ndixita force-pushed the pod-level-resources-beta branch from b776557 to 3f3e191 Compare June 12, 2025 17:13

k8s-ci-robot assigned tallclair Jun 12, 2025

haircommander reviewed Jun 12, 2025

View reviewed changes

keps/sig-node/2837-pod-level-resource-spec/README.md Outdated Show resolved Hide resolved

haircommander reviewed Jun 12, 2025

View reviewed changes

keps/sig-node/2837-pod-level-resource-spec/README.md Outdated Show resolved Hide resolved

ndixita force-pushed the pod-level-resources-beta branch from 3f3e191 to 5e556cc Compare June 12, 2025 20:12

ndixita changed the title ~~Adding details for CPU, memory and topology manager implementation an…~~ KEP-2837: Beta Graduation Criteria Jun 12, 2025

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025

ndixita force-pushed the pod-level-resources-beta branch from 5b51362 to 1d8e4df Compare June 18, 2025 23:24

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025

ndixita force-pushed the pod-level-resources-beta branch from 1d8e4df to 83bf364 Compare June 19, 2025 06:11

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025

soltysh reviewed Jun 19, 2025

View reviewed changes

raywainman reviewed Jun 19, 2025

View reviewed changes

keps/sig-node/2837-pod-level-resource-spec/README.md Outdated Show resolved Hide resolved

ndixita force-pushed the pod-level-resources-beta branch from 83bf364 to 88c0e23 Compare June 19, 2025 17:18

ndixita force-pushed the pod-level-resources-beta branch from 88c0e23 to a088c6e Compare June 19, 2025 17:34

Adding Beta implementation requirements

e8c51a7

Signed-off-by: ndixita <ndixita@google.com>

mrunalp approved these changes Jun 19, 2025

View reviewed changes

ndixita force-pushed the pod-level-resources-beta branch from a088c6e to e8c51a7 Compare June 19, 2025 17:36

k8s-ci-robot assigned jackfrancis Jun 19, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025

k8s-ci-robot assigned deads2k and soltysh Jun 19, 2025

soltysh approved these changes Jun 19, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025

k8s-ci-robot merged commit ef7e11d into kubernetes:master Jun 19, 2025
4 checks passed

k8s-ci-robot added this to the v1.34 milestone Jun 19, 2025

jackfrancis mentioned this pull request Jun 20, 2025

[KEP-2941]: Supporting Dynamic Resource Allocations in Kueue kubernetes-sigs/kueue#5149

Merged

toVersus mentioned this pull request Jun 23, 2025

Support Pod Level Resources kubernetes-sigs/karpenter#2325

Closed

This was referenced Jul 29, 2025

[PodLevelResources] Event for unsupported pod-level resource manager alignment kubernetes/kubernetes#133256

Closed

[PodLevelResources] handle pod-level resource manager alignment kubernetes/kubernetes#133279

Merged

KEP-2837: Beta Graduation Criteria for 1.34 #5362

KEP-2837: Beta Graduation Criteria for 1.34 #5362

Uh oh!

Conversation

ndixita commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jun 3, 2025

Uh oh!

pravk03 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ndixita commented Jun 12, 2025

Uh oh!

ndixita commented Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

mrunalp commented Jun 18, 2025

Uh oh!

tallclair commented Jun 18, 2025

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

soltysh Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

soltysh Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

ndixita Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

raywainman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jackfrancis commented Jun 19, 2025

Uh oh!

jackfrancis commented Jun 19, 2025

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

ndixita commented Jun 3, 2025 •

edited

Loading

pravk03 left a comment •

edited

Loading