Skip to content

KEP-4940: record implemented status for 1.34 #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2025
Merged

KEP-4940: record implemented status for 1.34 #5543

merged 1 commit into from
Sep 30, 2025
+5 −4

Conversation

@liggitt
Copy link
Member

@liggitt liggitt commented Sep 17, 2025 •
edited
Loading

Fix bookkeeping gap on implementable state and PRR review done for 1.34 (#4942 (review))

Closes #4940

/sig auth
/assign @deads2k

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2025
@liggitt liggitt mentioned this pull request Sep 17, 2025
Closed
4 tasks
@enj enj moved this to Needs Triage in SIG Auth Sep 18, 2025
@enj enj added this to SIG Auth Sep 18, 2025
tssurya
tssurya approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2025
@deads2k
Copy link
Contributor

deads2k commented Sep 30, 2025

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit fb5200e into kubernetes:master Sep 30, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 30, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed / Done in SIG Auth Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micahhausler micahhausler Awaiting requested review from micahhausler

@palnabarun palnabarun Awaiting requested review from palnabarun

1 more reviewer

@tssurya tssurya tssurya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tssurya tssurya

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG Auth
Archived in project

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

Add PSA to block setting .host field from ProbeHandler and LifecycleHandler

4 participants

@liggitt @deads2k @k8s-ci-robot @tssurya