-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-1441: Drop auto profile #5600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mochizuki875
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ardagucl
Thank you for your work.
I've left some comments.
| by examining the `pod-security.kubernetes.io/enforce` annotation on the namespace and | ||
| selecting the most permissive of "general", "baseline", and "restricted" that the | ||
| controller will allow. | ||
| Default profile will be `general`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
| Default profile will be `general`. | |
| `general` profile will become default profile, but in order to maintain backwards compatibility | |
| the `legacy` profile will be the default profile until the 1.25 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review. Updated this section for more clarity. Please let me know about your thoughts.
| Default profile will be `general`. | ||
|
|
||
| This will become the default behavior, but in order to maintain backwards compatibility | ||
| the "legacy" profile will be the default profile until the 1.25 release. When `--profile` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be out of scope for this update, should we update "1.25" to the version in which general becomes default?
Should we do this in kubernetes/kubectl#1780?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I reworded this section.
|
@ardaguclu |
soltysh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retroactively, this lgtm :)
One-line PR description: This PR updates KEP-1441 by dropping the auto profile mentions. We decided that we can default to
generalprofile.Issue link: KEP 1441 - kubectl debug #1441
Other comments: Agreed upon sig-cli biweekly meeting on October 1st 2025.