Skip to content

Conversation

@ardaguclu
Copy link
Member

  • One-line PR description: This PR updates KEP-1441 by dropping the auto profile mentions. We decided that we can default to general profile.

  • Issue link: KEP 1441 - kubectl debug #1441

  • Other comments: Agreed upon sig-cli biweekly meeting on October 1st 2025.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Oct 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Oct 2, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2025
@ardaguclu
Copy link
Member Author

/cc @soltysh @mochizuki875

Copy link
Member

@mochizuki875 mochizuki875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardagucl
Thank you for your work.
I've left some comments.

by examining the `pod-security.kubernetes.io/enforce` annotation on the namespace and
selecting the most permissive of "general", "baseline", and "restricted" that the
controller will allow.
Default profile will be `general`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

Suggested change
Default profile will be `general`.
`general` profile will become default profile, but in order to maintain backwards compatibility
the `legacy` profile will be the default profile until the 1.25 release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review. Updated this section for more clarity. Please let me know about your thoughts.

Default profile will be `general`.

This will become the default behavior, but in order to maintain backwards compatibility
the "legacy" profile will be the default profile until the 1.25 release. When `--profile`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be out of scope for this update, should we update "1.25" to the version in which general becomes default?
Should we do this in kubernetes/kubectl#1780?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I reworded this section.

@mochizuki875
Copy link
Member

@ardaguclu
Thank you !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 76a7c63 into kubernetes:master Oct 2, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 2, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Oct 2, 2025
@ardaguclu ardaguclu deleted the kep-1441-drop-auto branch October 2, 2025 07:59
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retroactively, this lgtm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants