-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-3314: updated to reflect the latest state #5670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
KEP-3314: updated to reflect the latest state #5670
Conversation
and the external snapshot metadata sidecar repository.
|
Hi @carlbraganza. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlbraganza The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
| > Note: It is the backup application's responsibility to determine if the | ||
| underlying CSI driver provides this support. | ||
| If it does, the backup application should take that into consideration in | ||
| its snapshot retention policy, and should save the CSI snapshot handle | ||
| somewhere for future use if it deletes the `VolumeSnapshot` object | ||
| immediately after it has performed a backup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any consideration to how backup application could delete the underlying snapshot handle from storage infra or is that left to the storage infra application outside the scope of backup application responsibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. In discussions in the WG meeting we decided that this issue is beyond the scope of the spec.
That would be something between the backup application and the storage infrastructure. The spec does not require support for 0 snapshot retention to exist; this change merely allows CBT to be used in such a circumstance.
In practical terms, in the only supported case that I'm aware of (VMware), and I believe there is no need to "delete" the previous snapshot handle, because it is just a tag in the disk file metadata.
Updated the KEP with relevant changes in the CSI spec and the external snapshot metadata sidecar repository.