Add additional metrics guideline violations to metrics overhaul #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/kep
k8s-ci-robot
added
sig/instrumentation
justaugustus
requested changes
Dec 17, 2018
| @@ -96,6 +96,10 @@ https://github.com/kubernetes/kubernetes/issues/68522 | |||
|
|
|||
| https://github.com/kubernetes/kubernetes/pull/63924 | |||
|
|
|||
| #### Prober metrics | |||
|
|
|||
| Make proper metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the Kubernetes instrumentation guidelines. | |||
There was a problem hiding this comment.
Suggested change
| Make proper metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the Kubernetes instrumentation guidelines. | |
| Make prober metrics introduced in https://github.com/kubernetes/kubernetes/pull/61369 conform to the Kubernetes instrumentation guidelines. |
There was a problem hiding this comment.
@brancz -- could you link out to the instrumentation guidelines here as well?
|
LGTM; I realized today I had also included this in kubernetes/kubernetes#69099 and I've updated the PR to reflect that. |
|
@ehashman awesome! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into the kubelet API, I noticed the existance of the
/metrics/probesendpoint, and noticed it violates the instrumentation guidelines in the same way as the cAdvisor labels do. Therefore adding those to the metrics overhaul KEP.@DirectXMan12 @ehashman @mxinden @piosz @coffeepac @s-urbaniak @metalmatze