CronJobs (previously ScheduledJobs)

[soltysh]

Enhancement Description

• One-line feature description (can be used as a release note):
  CronJobs (previously ScheduledJobs) are meant for performing all time-related actions, namely backups, report generation and the like. Each of these tasks should be allowed to run repeatedly (once a day/month, etc.) or once at a given point in time.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable
• Discussion Link: sig-apps agenda
• Primary contact (assignee): @soltysh
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  • Alpha release target 1.4 (as ScheduledJobs)
  • Beta release target 1.8 (as CronJobs)
  • Stable API target 1.21
  • Stable controller target 1.22
    • switch storage to batch/v1 CronJob: switch storage version to batch/v1 in 1.22 kubernetes#102363
    • switch kubectl prune (and addon manager prune whitelist) to batch/v1 Clean apply's prune and kube addons with batch/v1 CronJob kubernetes#102528
    • kubectl sparse tests Promote cronjob to batch/v1: kubectl sparse_test file kubernetes#102338
    • switch kubectl create job owner ref to batch/v1 Drop beta APIs from create command for PDBs and CronJobs kubernetes#101613
    • switch controller to use batch/v1 Switch cronjob controller to batch/v1 kubernetes#99423
    • test fixes Promote cronjob integration test to batch/v1 kubernetes#102143
    • feature flag GA Promote CronJobControllerV2 flag to GA kubernetes#102529 & Promote CronJobControllerV2 flag to GA website#28229
    • various minor fixes fix: inaccurate miss schedule times of cronjob v2. kubernetes#101055
    • update cron library Update to github.com/robfig/cron/v3 kubernetes#102735
    • set lastSuccessfull populate last successful time to cronjob status kubernetes#102642
• Remove old controller target 1.23
  • Remove GAed feature gate CronJobControllerV2 kubernetes#104470

[soltysh]

@erictune fyi

[philips]

@soltysh On what SIG can I discuss this feature? I want to have a longer discussion about third-party resources for this feature and why we feel it needs to be built into core.

[erictune]

Let's use SIG-Apps for now. There has not been a lot of discussion of controllers there, that I have seen, but lets try and see how it goes.

[gtaylor]

Is this being considered for exclusion from the core? I had thought the proposal was already accepted.

[soltysh]

@gtaylor nothing has been decided yet. Currently it'll be part of alpha group in batch, what will happen when this migrates to more stable is not yet known.

[davidopp]

My understanding was that this was accepted into core, while job workflow was rejected for core. In fact we had originally planned to have it in 1.3.

[soltysh]

@davidopp my comment was based on the discussion we've previously had with @philips @erictune here. Although, personally I'd prefer SJ stay in the core 😎

[davidopp]

@soltysh I interpreted the comment as implying that it would be in core (based on the mention of alpha/beta and the statement "If someone were to produce a third-party version of scheduledJob, well before 1.4, and show that was comparably useful, that would be persuasive argument for the latter path" where the latter path was ThirdParty).

[erictune]

@davidopp that comment was made when I thought SJ would be Beta in 1.4. Now it is going to Alpha in 1.4. The philosophy was that we can cancel an alpha feature for whatever reason, but we should have a pretty high bar for cancelling a beta feature.

[erictune]

Also, to all working on SJ: we should continue work at full speed, despite the above conversation. Much of the work will apply either way, and we need to get some kind of feature out to users so they can give feedback.

[soltysh]

All SJ work is at full speed, the only remaining problem (hopefully) is to have kubernetes/kubernetes#29187 in. I'm hoping to discuss this issue with @smarterclayton today or over the weekend and have it merged so next week we should see one after the other SJ PRs being merged.

[eghobo]

@soltysh: it looks like #29187 was merged, does it mean next 1.4 alpha release will have SJ ready to play?

[soltysh]

@eghobo that's the plan.

[erictune]

This needs docs in k8s.io, but it looks like code is in. Awesome!

[davidopp]

+100

[janetkuo]

@soltysh are docs considered done or are you adding more examples / tutorials? If docs are done we can check the docs box

[soltysh]

@janetkuo I usually mark them done once they merge. With that in mind I've checked the one against branch 1.4, the other will wait for merge.

[soltysh]

Since this was renamed to CronJobs I'll update the title to reflect that change as well.

[ConorNevin]

Is this going to be in beta for 1.5?

[soltysh]

@ConorNevin unfortunately not, see the beta requirements in the issue description what we need to address first to promote it to beta. Sorry 😞 Help with fixing those is highly encouraged though 😃

[soltysh]

@JamesLaverack all PRs as outlined in the description, just checked we're all good 👍

[salaxander]

Hey @soltysh - Could you open a PR on the KEP to mark the status as implemented? At that point we can close out the issue.

Thanks!!

[mengjiao-liu]

Per https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable#release-122 we'll remove the old controller. But the old controller code hasn't been cleaned up. Is there a plan? @soltysh

[soltysh]

Hey @soltysh - Could you open a PR on the KEP to mark the status as implemented? At that point we can close out the issue.

@salaxander opened #2925 fixing it

The issue can't be closed, yet. We need to get rid of the old controller in 1.23 as the last element.

/milestone v1.23

[salaxander]

Hey @soltysh - 1.23 enhancements lead here! Are we just tracking the removal of the old controller for this release? We've got a PRR freeze in effect starting tomorrow, but that shouldn't impact this

[soltysh]

That's my thinking as well, the feature is off, we're just removing the ability to turn it on as pointed out in https://github.com/kubernetes/kubernetes/blob/2a88664eccdf02cd01777b48171873a028117737/pkg/features/kube_features.go#L841 so that's not requiring PRR.

[jlbutler]

Hi @soltysh! 1.23 Docs team here.

This enhancement issue is listed as 'None required' for docs in the tracking sheet. I wanted to confirm we don't have any changes related to this (feature gate docs, deprecation/removal notes, etc)?

If not, please confirm and all good on our end. Otherwise, please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Thanks!

[chrisnegus]

Hi @soltysh! I'm a 1.23 docs release team shadow. I'm checking that there is no documentation needed for this feature.

CronJobControllerv2 is mentioned in the following K8s docs: Feature Gates and CronJob, Please confirm that the text in those places does not need to change. If changes are needed, please create a PR placeholder for the changes before Thu November 18, 11:59 PM PDT. Thanks!

[soltysh]

@chrisnegus since we're removing the feature gate in kubernetes/kubernetes#104470 I've opened kubernetes/website#30344

[chrisnegus]

Thanks @soltysh! Does that cover the extent of changes you want to make? Is it ready to review?

[soltysh]

@chrisnegus yes, this is mostly cleaning bits after the old controller.

[soltysh]

Since the doc's folks recommended not changing the feature gate table, this is all ready now.
@chrisnegus this can be closed when we release 1.23

[chrisnegus]

Since the doc's folks recommended not changing the feature gate table, this is all ready now. @chrisnegus this can be closed when we release 1.23

Thanks @soltysh !

[gracenng]

Enhancements graduated to stable, implemented status in KEP.