Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote CronJobControllerV2 flag to GA #102529

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Promote CronJobControllerV2 flag to GA #102529

merged 1 commit into from
Jun 3, 2021

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Jun 2, 2021

What type of PR is this?

/kind feature
/sig apps

What this PR does / why we need it:

Promote CronJobControllV2 feature flag to GA.

Which issue(s) this PR fixes:

xref: kubernetes/enhancements#19

Special notes for your reviewer:

/assign @alaypatel07

Does this PR introduce a user-facing change?

Promote CronJobControllerV2 flag to GA, with removal in 1.23

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/19-Graduate-CronJob-to-Stable

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 2, 2021
@soltysh
Copy link
Contributor Author

soltysh commented Jun 2, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 2, 2021
@soltysh soltysh mentioned this pull request Jun 2, 2021
Closed
16 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@soltysh soltysh mentioned this pull request Jun 2, 2021
Merged
pacoxu
pacoxu reviewed Jun 2, 2021
View reviewed changes
pkg/features/kube_features.go
@@ -840,8 +840,8 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
StartupProbe: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.23
AllowInsecureBackendProxy: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.23
PodDisruptionBudget: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.25
CronJobControllerV2: {Default: true, PreRelease: featuregate.Beta},
DaemonSetUpdateSurge: {Default: true, PreRelease: featuregate.Beta}, // on by default in 1.22
CronJobControllerV2: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#L508-L509

	// This feature is deprecated, and will be removed in v1.22.	
	CronJobControllerV2 featuregate.Feature = "CronJobControllerV2"

The comment above needs an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@soltysh
Copy link
Contributor Author

soltysh commented Jun 2, 2021

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 2, 2021
@pacoxu
Copy link
Member

pacoxu commented Jun 3, 2021

/lgtm
/retest
for flake which will be fixed with #102521

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1677d93 into kubernetes:master Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 3, 2021
@soltysh soltysh deleted the cronjob_fflag branch June 9, 2021 11:40
@pacoxu pacoxu mentioned this pull request Aug 20, 2021
Merged
@reylejano reylejano mentioned this pull request Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@dims dims Awaiting requested review from dims

Assignees

@pacoxu pacoxu

@alaypatel07 alaypatel07

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@soltysh @k8s-ci-robot @pacoxu @alaypatel07