StorageObjectInUseProtection (was Persistent Volume Claim Protection)

[pospispa]

Feature Description

• One-line feature description (can be used as a release note): Prevent deletion of Storage Object that is In active Use (was Prevent deletion of Persistent Volume Claims that are used by a pod in 1.9)
• Primary contact (assignee): Pavel Pospisil (@pospispa)
• Responsible SIGs: @kubernetes/sig-storage-feature-requests
• Design proposal link (community repo): Postpone Deletion of a Persistent Volume Claim in case It Is Used by a Pod community#1174
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • @msau42
  • @jsafrane
• Approver (likely from SIG/area to which feature belongs): @jsafrane
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y): 1.9
  • Beta release target (x.y): 1.10
  • Stable release target (x.y): 1.11

[pospispa]

/assign

[pospispa]

This feature aims to fix the bug: kubernetes/kubernetes#45143

[saad-ali]

PR implementing this feature: https://github.com/kubernetes/kubernetes/pull/55824/files

[zacharysarah]

@pospispa 👋 Please indicate in the 1.9 feature tracking board
whether this feature needs documentation. If yes, please open a PR and add a link to the tracking spreadsheet. Thanks in advance!

[pospispa]

@zacharysarah it seems I don't have write permission for the 1.9 feature tracking board.
Anyway, this feature needs documentation and a documentation PR is opened:
kubernetes/website#6415

[stewart-yu]

Does have progress in this feature? I want to track about it

[pospispa]

The alpha version of this feature is merged. PRs:

• Postpone Deletion of a Persistent Volume Claim in case It Is Used by a Pod kubernetes#55824
• kubectl: Add Terminating state to PVCs kubernetes#55873

The alpha version doesn't include changes to scheduler that are not critical for the alpha version. Changes into scheduler are already approved (kubernetes/kubernetes#55957) and will be merged into K8s 1.10.

Documentatio PR is open and documentation is under review.

To sum it up, the alpha version of this feature should be released in K8s 1.9.

[saad-ali]

This feature is planned to move to beta in 1.10

[MikeSpreitzer]

Is kubernetes/community#1174 supposed to work when pods and PVCs are stored in different etcd clusters?

[liggitt]

Is kubernetes/community#1174 supposed to work when pods and PVCs are stored in different etcd clusters?

Yes, it works via finalizers on the API objects. It doesn't matter if those resources are backed by different etcd clusters.

Out of curiosity, are you aware of a setup that overrides etcd configuration to store PV and PVC objects in different etcd clusters?

[justaugustus]

@pospispa
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

• Description
• Milestone
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

cc @idvoretskyi

[msau42]

/assign @tsmetana

[pospispa]

/milestone 1.11
/stage stable

[pospispa]

@tsmetana @jsafrane please, would you update the labels to:
/milestone 1.11
/stage stable
as I don't have permissions for it.

[pospispa]

@justaugustus I'd like to bring this feature to GA. I've created a PR: kubernetes/kubernetes#62870

Note: documentation changes are in PR kubernetes/website#7775 that should be re-opened after the source code is merged.

I've updated the feature description.

I don't have permission to update milestone and labels, but I hope @tsmetana or @jsafrane will update them.

[justaugustus]

Thanks for the update!

[pospispa]

PR kubernetes/kubernetes#62870 got merged.

[mdlinville]

Are this and #499 both covered by Docs PR kubernetes/website#8159? They are separate line items in the release spreadsheet for 1.11.

[pospispa]

@MistyHacks yes, both are covered by kubernetes/website#8159
Originally they were planned as separate features for 1.9, but they were merged into StorageObjectInUseProtection feature in 1.10.

[AishSundar]

@pospispa I am the CI Signal lead for 1.11 and also work on Conformance testing program for K8s. I see this feature is going to Stable in 1.11.
I assume you already have e2e tests for it. I am following up to see if and which of those tests should we promote to the conformance suite in 1.11
As part of the process to increase conformance coverage, outlined by Conformance WG and Sig-Arch, we expect features going into stable/GA to have representation in Conformance suite. Your update on the same will help us evaluate this feature better.

[msau42]

General discussion for PVC/PV conformance testing here: kubernetes/kubernetes#65155

[kacole2]

@pospispa This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12. This still has the 1.11 milestone as well so we need to update it accordingly.

Can you please update the feature milestone tracking in the original post as well?
If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

[msau42]

This feature went GA in 1.11. I think this can be closed?

[justaugustus]

Good catch, @msau42!
/close