Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP Waiting for Source Code Merge] Bring StorageObjectInUseProtection feature to GA #7775

Conversation

pospispa
Copy link

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>

Please delete this note before submitting the pull request.

Allow edits from maintainers checkbox

Bradamant3 and others added 30 commits January 30, 2018 12:41
* Fix partition value expected behaviour explanation (kubernetes#7123)

Fixes issue kubernetes#7057

* Correct "On-Premise" to "On-Premises"

* Updates the Calico installation page (kubernetes#7094)

* All files for Haufe Groups case study (kubernetes#7051)

* Fix typo (kubernetes#7127)

* fix typo of device-plugins.md (kubernetes#7106)

* fix broken links (kubernetes#7136)

* Updated configure-service-account (kubernetes#7147)

Error from server resolved by escaping kubectl patch serviceaccount default -p '{"imagePullSecrets": [{"name": "myregistrykey"}]}' JSON string by '\'
With kubernetes/kubernetes#58367 merged, v1.10 will not use the
"require-kubeconfig" flag. The flag has become a no-op solely to ensure
existing deployments won't break.
…State (kubernetes#7164)

The below PR:
kubernetes/kubernetes#55873
modified scheduler in such a way that scheduling of a pod that uses a PVC in Terminating state fails.

That's why verification of such scenario was added to documentation.
…s#7140)

With kubernetes/kubernetes#58978 merged, the said feature gate is
removed. This PR removes texts related to the gate and revises the
Feature Gates reference to reflect this change.
The `Accelerators` feature gate will be removed in 1.11. 1.10 will be
its last mile.
References: kubernetes/kubernetes#57384
The `HugePages` feature gate has graduated to Beta in v1.10. This PR
documents this fact.
* Kms provider doc

* issue# 7399, Create KMS-provider.md and update encrypt-data.md

* address review comments
* Add docs for CRD features for 1.10

* Add CustomResourcesSubresources to list of feature gates

* Add latest changes to custom resources doc
* Bring PVC Protection Feature to Beta

The PR: kubernetes/kubernetes#59052
brought PVC Protection feature to beta.

That's why the documentation is updated accordingly.

* The PVC Protection feature was renamed to Storage Protection. That's why the documentation is updated.
…etes#7134)

* promote PodNodeSelector to stable; document detailed behavior

* respond to feedback
With `CPUManager` feature graduating to beta. No explicit enabling is
required starting v1.10.
References: kubernetes/kubernetes#55977
…7531)

Code review comments.

Changed property to field.

Address tech review comment.
--show-all has been deprecated and set to true by default.
kubernetes/kubernetes#60210
s/simultanously/simultaneously/
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: a-mccarthy

Assign the PR to them by writing /assign @a-mccarthy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2018
@pospispa
Copy link
Author

pospispa commented Mar 18, 2018

/hold
rebase from release-1.10 to master will be needed
waiting for source code merge; PR kubernetes/kubernetes#61325

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 18, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit eee4f5c

https://deploy-preview-7775--kubernetes-io-master-staging.netlify.com

StorageObjectInUseProtection is Beta in K8s 1.10.

It's brought to GA in K8s 1.11.
@pospispa pospispa force-pushed the Bring-StorageObjectInUseProtection-feature-to-GA branch from f35b1fd to eee4f5c Compare March 18, 2018 19:07
@Bradamant3
Copy link
Contributor

/assign

@pospispa can you please do the rebase to release-1.10 soon, without waiting for source code merge? Thanks!

@Bradamant3 Bradamant3 added this to the 1.10 milestone Mar 19, 2018
@pospispa
Copy link
Author

This PR is for K8s 1.11. So I better close it create it once again later.

@pospispa pospispa closed this Mar 19, 2018
@Bradamant3
Copy link
Contributor

Bradamant3 commented Mar 19, 2018

@pospispa whoops, sorry, did not see that. The release team is a bit hypervigilant on this feature atm. Although yeah even late at night I should have remembered that you're in beta for 1.10. I can let you know as soon as the release-1.11 branch is created, bc I'll be helping run docs for 1.11 also. But let me ask around on the team. I am pretty sure we want to wait a couple of weeks, to minimize the need for merges from master to keep the release branch reasonably fresh. Adding the 1.11 milestone now, though, even though the PR is closed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.