Skip to content

Error cloning repositories without branch "master" #444

Closed
@GabrielDyck

Description

@GabrielDyck

Hi!

I have an issue when flag GIT_SYNC_BRANCH is not set. This component requires know an existing branch of a repository or the repo must have a branch named "master".

Nowaways, new projects are created with main branch instead of master, and when we use this tool it throws an error.

I reviewed the repo and in this function

// CloneRepo does an initial clone of the git repo.
func (git *repoSync) CloneRepo(ctx context.Context) error {
args := []string{"clone", "--no-checkout", "-b", git.branch}

and this line

_, err := git.run.Run(ctx, git.root, git.cmd, "worktree", "add", worktreePath, "origin/"+git.branch, "--no-checkout")

we can make git.branch optional and also change default value from "master" to "" in GIT_SYNC_BRANCH param.

I did some tests with modified code and it worked fine.

Let me know your thoughts.

Thank you in advance!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions