Error cloning repositories without branch "master"

[GabrielDyck]

Hi!

I have an issue when flag GIT_SYNC_BRANCH is not set. This component requires know an existing branch of a repository or the repo must have a branch named "master".

Nowaways, new projects are created with main branch instead of master, and when we use this tool it throws an error.

I reviewed the repo and in this function

// CloneRepo does an initial clone of the git repo.
func (git *repoSync) CloneRepo(ctx context.Context) error {
args := []string{"clone", "--no-checkout", "-b", git.branch}

and this line

_, err := git.run.Run(ctx, git.root, git.cmd, "worktree", "add", worktreePath, "origin/"+git.branch, "--no-checkout")

we can make git.branch optional and also change default value from "master" to "" in GIT_SYNC_BRANCH param.

I did some tests with modified code and it worked fine.

Let me know your thoughts.

Thank you in advance!

[thockin]

Unfortunately that is a potentially breaking change and would require a major version bump. I want to do it, but I have some other major work that I want to do, and I don't really want to version-bump twice.

…

On Thu, Sep 23, 2021, 4:44 PM Gabriel Fernando Dyck < ***@***.***> wrote: Hi! I'm have an issue when flag GIT_SYNC_BRANCH is not set. This library requires know an existing branch of a repository or the repo must have a branch named "master". Nowaways, new proyects are created with main branch instead of master, and when we use this tool it throwns an error. I watched the repo and in this function // CloneRepo does an initial clone of the git repo. func (git *repoSync) CloneRepo(ctx context.Context) error { args := []string{"clone", "--no-checkout", "-b", git.branch} and this line _, err := git.run.Run(ctx, git.root, git.cmd, "worktree", "add", worktreePath, "origin/"+git.branch, "--no-checkout") we can make git.branch optional and also change default value from "master" to "" in GIT_SYNC_BRANCH param. I did some tests with modified code and works fine. Let me know your thoughts. Thank you in advance! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#444>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVHXZY2DOXO5HGMESI3UDO3XTANCNFSM5EUYVNXA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

Dup of #286