Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move git-sync to a new repo of its very own #1

Merged
merged 2 commits into from
Aug 22, 2016

Conversation

thockin
Copy link
Member

@thockin thockin commented Aug 20, 2016

This just imports the existing state of contrib/git-sync into this new repo and scrubs paths for "contrib". I have some further work I want to do on this sidecar, so I thought it was time to break it out.

@mikedanese
Copy link
Member

@thockin
Copy link
Member Author

thockin commented Aug 21, 2016

The process doesn't apply well to code that is moving from and existing
repo. If I recall, we just bypassed the process, but I'll go re-read it.

On Aug 20, 2016 9:44 PM, "Mike Danese" notifications@github.com wrote:

There is a process for new repos now https://docs.google.com/
document/d/1ugAd9Zj-jW3YHdrNVdktmvDMEWtChPqyGHfkwWdQ3zo/edit#heading=h.
bv4kogapeb2x


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVKN19xWXzYV_lWRvOIFNfN7-2q4Wks5qh9eYgaJpZM4JpL8Q
.

@thockin
Copy link
Member Author

thockin commented Aug 22, 2016

Yeah, this falls under the "existing" section:

New Kubernetes Community Projects can be created by pulling out code from the Kubernetes main repo ...
To do this the OWNERS of that package can directly graduate to a Kubernetes Community Project...

That said, I have some significant followups to this, so a rubber stamp is all that is required, really.

@mikedanese
Copy link
Member

Conveniently you left out the (except contrib/)

New Kubernetes Community Projects can be created by pulling out code from the Kubernetes main repo (except contrib/).

I'm not sure how this is an improvement over what we currently have but I'm not familiar enough with the new process (and I don't even know if it's been enacted yet (seems like it hasn't since https://github.com/kubernetes-incubator is empty)). I give this the rubber stamp.

@mikedanese mikedanese merged commit 2ed0e3f into kubernetes:master Aug 22, 2016
@thockin
Copy link
Member Author

thockin commented Aug 22, 2016

the "except contrib/" is about the existing kubernetes/kubernetes/contrib
rather than kubernetes/contrib. Parse that! :)

On Mon, Aug 22, 2016 at 9:27 AM, Mike Danese notifications@github.com
wrote:

Conveniently you left out the (except contrib/)

New Kubernetes Community Projects can be created by pulling out code from
the Kubernetes main repo (except contrib/).

I'm not sure how this is an improvement over what we currently have but
I'm not familiar enough with the new process (and I don't even know if it's
been enacted yet (seems like it hasn't since
https://github.com/kubernetes-incubator is empty)). I give this the
rubber stamp.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVHxLXA1DuujbZy4fj6Dkx-yPI_duks5qic34gaJpZM4JpL8Q
.

@mikedanese
Copy link
Member

The quote also says main repo, which this code was not in. When it was in the main repo, it was in contrib/,

@thockin
Copy link
Member Author

thockin commented Aug 22, 2016

OK, then I have no idea what the "except contrib" means in this context. I
can't copy it to my personal repo because it's not really mine. Whatever,
done for now.

On Mon, Aug 22, 2016 at 3:42 PM, Mike Danese notifications@github.com
wrote:

The quote also says main repo, which this code was not in. When it was in
the main repo, it was in contrib/,


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVKpKhZF_8hOSBbx9TAGlwvrbWLNdks5qiiXXgaJpZM4JpL8Q
.

@mikedanese
Copy link
Member

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants