Add help and manual flags, use pflag #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Some git revs now use "main" but "master" is still coded into git-sync. When that is fixed we can undo this.
THIS IS A BREAKING CHANGE Switch flags implementation to use pflag. This means that long flags like `-username` must now use 2 dashes: `--username`. The `-v` flag (verbose) used to accept `-v` or `--v`. Now it only accepts `-v. The `--help` and `-h` flags are new. The `--man` flag is new (print a man-page like help message). Several glog flags which used to be exposed (e.g. --logtostderr) are no longer exposed. Logs always go to stderr.
stp-ip
approved these changes
Nov 5, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stp-ip, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The docs are manually managed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING CHANGE, beginning the v4.x dev cycle.
Switch flags implementation to use pflag. This means that long flags
like
-usernamemust now use 2 dashes:--username.The
-vflag (verbose) used to accept-vor--v. Now it onlyaccepts `-v.
The
--helpand-hflags are new.The
--manflag is new (print a man-page like help message).Several glog flags which used to be exposed (e.g. --logtostderr) are no
longer exposed. Logs always go to stderr.
xref #284