Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CONTRIBUTING.md to CNCF CLA #317

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Change CONTRIBUTING.md to CNCF CLA #317

merged 1 commit into from
Dec 23, 2020

Conversation

thockin
Copy link
Member

@thockin thockin commented Dec 22, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2020
@k8s-ci-robot k8s-ci-robot requested a review from stp-ip December 22, 2020 23:24
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@stp-ip
Copy link
Member

stp-ip commented Dec 23, 2020

Same comment here as well: #318 (review)

@thockin
Copy link
Member Author

thockin commented Dec 23, 2020

I just C-N-P'ed from k/k/ My bad. How's this?

stp-ip
stp-ip approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ce96b3 into kubernetes:release-3.x Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stp-ip stp-ip stp-ip approved these changes

Assignees

@stp-ip stp-ip

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thockin @stp-ip @k8s-ci-robot