Add --git-config flag

[thockin]

This allows arbitrary git configs to be passed in. For example:

git config --global http.postBuffer 1048576000

git config --global http.sslCAInfo /path/to/cert/file

git config --global http.sslVerify false

This flag takes a comma-separated list of key:val pairs. The key part
is passed to git config and must be a valid gitconfig section header
and variable name. The val part can be either a quoted or unquoted
value. For all values the following escape sequences are supported:

• \n => [newline]
• \t => [tab]
• \" => "
• \, => ,
• \\ => \

Within unquoted values, commas MUST be escaped. Within quoted values,
commas MAY be escaped, but are not required to be. Any other escape
sequence is an error.

Example:

--git-config=foo.one:val1,foo.two:"quoted val",foo.three:12345

This commit exposed a bug in runCommand() which modified its args when
they had an embedded space.

Replaces #240 (thanks to @onesolpark for starting it)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@thockin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stp-ip]

Ran into an issue. Investigating.

[thockin]

I think tests on master (v4) are unhappy. I can tackle that independently. /hold

…

On Mon, Mar 15, 2021 at 8:33 AM Michael Grosser ***@***.***> wrote: Ran into an issue. Investigating. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#342 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVBCUPQ7LHKKM5PB7NDTDYSDFANCNFSM4Y7USZWA> .

[stp-ip]

Yeah. I missed that in the review #351 as far as I can see. It's due to the file/dir being ambigious to the revision as we removed the "rev-".
Will check it out and overall shouldn't be a blocker here once I boiled down the issue I guess.

[thockin]

I have a trivial fix - coming momentarily.

…

On Mon, Mar 15, 2021 at 8:58 AM Michael Grosser ***@***.***> wrote: Yeah. I missed that in the review #351 <#351> as far as I can see. It's due to the file/dir being ambigious to the revision as we removed the "rev-". Will check it out and overall shouldn't be a blocker here once I boiled down the issue I guess. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#342 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVAKLVNSYN6FND5GZWLTDYVBRANCNFSM4Y7USZWA> .

[thockin]

#353

…

On Mon, Mar 15, 2021 at 8:59 AM Tim Hockin ***@***.***> wrote: I have a trivial fix - coming momentarily. On Mon, Mar 15, 2021 at 8:58 AM Michael Grosser ***@***.***> wrote: > Yeah. I missed that in the review #351 > <#351> as far as I can see. > It's due to the file/dir being ambigious to the revision as we removed the > "rev-". > Will check it out and overall shouldn't be a blocker here once I boiled > down the issue I guess. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#342 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABKWAVAKLVNSYN6FND5GZWLTDYVBRANCNFSM4Y7USZWA> > . >

[stp-ip]

/hold cancel
/lgtm

[stp-ip]

/lgtm