Fix exit non-zero exit codes when running as pid1 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
thockin
force-pushed
the
fix-pid1-exit-code-v4
branch
from
8f58279 to
5fa0acc
Compare
k8s-ci-robot
added
size/L
thockin
force-pushed
the
fix-pid1-exit-code-v4
branch
from
5fa0acc to
64a3282
Compare
stp-ip
approved these changes
Mar 15, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stp-ip, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(v4 branch) Prior to this we would swallow the exit code and always exit(0).
thockin
force-pushed
the
fix-pid1-exit-code-v4
branch
from
64a3282 to
45b2853
Compare
|
Typo fixed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
bbguimaraes
added a commit
to bbguimaraes/release
that referenced
this pull request
Dec 9, 2022
Update to the latest version (apparently hosted elsewhere now): https://github.com/kubernetes/git-sync/releases/tag/v3.6.2 Fixes silliness such as: - openshift#34630 (comment) - kubernetes/git-sync#344
openshift-merge-robot
pushed a commit
to openshift/release
that referenced
this pull request
Dec 9, 2022
Update to the latest version (apparently hosted elsewhere now): https://github.com/kubernetes/git-sync/releases/tag/v3.6.2 Fixes silliness such as: - #34630 (comment) - kubernetes/git-sync#344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(v4 branch)
Prior to this we would swallow the exit code and always exit(0).