Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the root directory if it doesn't exist #383

Merged
merged 1 commit into from
May 21, 2021
Merged

Create the root directory if it doesn't exist #383

merged 1 commit into from
May 21, 2021

Conversation

nan-yu
Copy link
Contributor

@nan-yu nan-yu commented May 12, 2021

The git clone command will create the root directory if it doesn't
exist, but if git clone fails, the root directory needs to be present
so that we can write the error to a file under the directory.

@nan-yu
Create the root directory if it doesn't exist
59f8f6a 
The `git clone` command will create the root directory if it doesn't
exist, but if `git clone` fails, the root directory needs to be present
so that we can write the error to a file under the directory.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2021
@k8s-ci-robot k8s-ci-robot requested review from stp-ip and thockin May 12, 2021 00:04
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2021
thockin
thockin reviewed May 21, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you port to master branch too ?

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nan-yu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 246584d into kubernetes:release-3.x May 21, 2021
@nan-yu
Copy link
Contributor Author

nan-yu commented May 21, 2021

Thanks! Can you port to master branch too ?

/lgtm
/approve

Sure. Please check #385.

Can we have a release for the fix?

thockin added a commit to thockin/git-sync that referenced this pull request May 21, 2021
@thockin
Port kubernetes#383 (make root dir) to v4
0304d03
thockin added a commit to thockin/git-sync that referenced this pull request May 22, 2021
@thockin
Port kubernetes#383 (make root dir) to v4
8999ca8
thockin added a commit to thockin/git-sync that referenced this pull request May 22, 2021
@thockin
Port kubernetes#383 (make root dir) to v4
59c11de
@thockin
Copy link
Member

thockin commented May 24, 2021

https://github.com/kubernetes/git-sync/releases/tag/v3.3.1 - waiting for the image to be promoted.

@nan-yu
Copy link
Contributor Author

nan-yu commented May 24, 2021

https://github.com/kubernetes/git-sync/releases/tag/v3.3.1 - waiting for the image to be promoted.

Thanks @thockin . I did an integration test with the latest image. Unfortunately, we need another fix for the error file's read permission. I pushed up two PRs: #389 and #390 for review. I verified this is the last fix to make the error file readable to other containers.

I'm sorry for not capturing them earlier. I should have run the test before the release.
Please take a look at these PRs and make a new release. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@stp-ip stp-ip Awaiting requested review from stp-ip

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nan-yu @k8s-ci-robot @thockin