Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't double-register the hook metric (v4) #476

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Don't double-register the hook metric (v4) #476

merged 1 commit into from
Jan 23, 2022

Conversation

thockin
Copy link
Member

@thockin thockin commented Jan 22, 2022

xref #474

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip January 22, 2022 22:27
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2022
@thockin thockin changed the title Don't double-register the hook metric Don't double-register the hook metric (v4) Jan 22, 2022
stp-ip
stp-ip approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 10fd8e6 into kubernetes:master Jan 23, 2022
@thockin thockin deleted the v4-double-register-hook-metric branch February 25, 2023 22:50
@p-linnane p-linnane mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stp-ip stp-ip stp-ip approved these changes

@nan-yu nan-yu Awaiting requested review from nan-yu

Assignees

@stp-ip stp-ip

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thockin @k8s-ci-robot @stp-ip