Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug caused in previous PR (v4) #480

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

thockin
Copy link
Member

@thockin thockin commented Jan 24, 2022

The .git to check is not the root/.git but the link/.git - tests pass now.

The .git to check is not the root/.git but the link/.git - tests pass now.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2022
@thockin
Copy link
Member Author

thockin commented Jan 24, 2022

Self-merge to fix v4 branch

@thockin thockin merged commit f24435f into kubernetes:master Jan 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip January 24, 2022 19:14
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@stp-ip
Copy link
Member

stp-ip commented Jan 25, 2022

Sorry I missed that.

@thockin
Copy link
Member Author

thockin commented Jan 25, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants