Drop distroless and DIY #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
thockin
force-pushed
the
v4_drop_distroless
branch
from
5ea67c5 to
1cd324e
Compare
|
Looks good, but one question... why do we do this in stage_binaries.sh? Is apt / dpkg available in the final image? Is it used somewhere in the staging process? |
justinsb
reviewed
Jul 28, 2023
|
re /var/lib/dpkg/status.d/ - apt is not in the final image. This seems to be the negotiated truce between such images (including those created by bazel) and security scanners. Just enough metadata to satisfy trivy. |
Distroless is stuck on debian 11 - we can do the same thing, more or less in our own script. Sad that we have to, but here we are. The net result is a about 8MB smaller and passes e2e and passes trivy.
thockin
force-pushed
the
v4_drop_distroless
branch
from
1cd324e to
a56f58d
Compare
|
Added some comments |
|
Result: 57.7MB A build looks like: |
|
Great to know how we can fix all CVEs ;-) /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distroless is stuck on debian 11 - we can do the same thing, more or less in our own script. Sad that we have to, but here we are.
The net result is a about 8MB smaller and passes e2e and passes trivy.
Fixes #779
Fixes #780