Skip to content

Add /tmp to staging #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Add /tmp to staging #794

merged 1 commit into from
Jul 31, 2023

Conversation

thockin
Copy link
Member

@thockin thockin commented Jul 31, 2023

Fix #793

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: thockin / name: Tim Hockin (7a72116)

@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip July 31, 2023 15:37
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2023
@thockin
Copy link
Member Author

thockin commented Jul 31, 2023

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 31, 2023
@@ -68,8 +68,7 @@ RUN /stage_binaries.sh -o {ARG_STAGING} \
-f /etc/nsswitch.conf \
-f /etc/os-release \
-f /etc/passwd \
-f /etc/shadow
RUN ln -sf /bin/dash {ARG_STAGING}/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed deliberately or misclick?

@justinsb
Copy link
Member

I believe this will copy the permissions for /tmp (which are particularly important), because we use cp -a

LGTM though I wasn't sure whether you deliberately removed the dash symlink, so will add a hold but feel free to remove hold if deliberate.

/approve
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thockin
Copy link
Member Author

thockin commented Jul 31, 2023

/etc/shadow is not needed

The symlink to dash is already covered by the dash package (redundant)

This does retain /tmp permissions:

$ make container
<...lots ot output...>
container: gcr.io/k8s-staging-git-sync/git-sync:v4.0.0-rc4-1-g7a72116__linux_amd64

$ docker run -ti --entrypoint "" gcr.io/k8s-staging-git-sync/git-sync:v4.0.0-rc4-1-g7a72116__linux_amd64 ls -ld /tmp
drwxrwxrwt 2 root root 4096 Jul 31 15:18 /tmp

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5e5035d into kubernetes:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.0-rc4 error with permission denied in /tmp
3 participants