-
Notifications
You must be signed in to change notification settings - Fork 431
Add /tmp to staging #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /tmp to staging #794
Conversation
|
/easycla |
@@ -68,8 +68,7 @@ RUN /stage_binaries.sh -o {ARG_STAGING} \ | |||
-f /etc/nsswitch.conf \ | |||
-f /etc/os-release \ | |||
-f /etc/passwd \ | |||
-f /etc/shadow | |||
RUN ln -sf /bin/dash {ARG_STAGING}/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed deliberately or misclick?
I believe this will copy the permissions for LGTM though I wasn't sure whether you deliberately removed the dash symlink, so will add a hold but feel free to remove hold if deliberate. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/etc/shadow is not needed The symlink to dash is already covered by the dash package (redundant) This does retain /tmp permissions:
|
Fix #793