Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --credential flag for multiple username/password #803

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Add --credential flag for multiple username/password #803

merged 1 commit into from
Oct 8, 2023

Conversation

thockin
Copy link
Member

@thockin thockin commented Sep 9, 2023 •
edited
Loading

fixes #425
fixes #796

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2023
@thockin thockin force-pushed the http_auth branch 4 times, most recently from c92bc55 to 4640f1c Compare September 12, 2023 21:37
@thockin thockin force-pushed the http_auth branch 2 times, most recently from 7a13146 to 24dd27e Compare September 20, 2023 16:32
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2023
@thockin thockin force-pushed the http_auth branch 2 times, most recently from cdc37d3 to f4cbb6d Compare September 22, 2023 02:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 22, 2023
@thockin thockin force-pushed the http_auth branch 2 times, most recently from 374c838 to 3c0e5a8 Compare September 26, 2023 15:46
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2023
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 26, 2023
@thockin thockin changed the title WIP: Add tests for HTTP password auth WIP: Add --credential flag for multiple username/password Sep 26, 2023
@thockin thockin force-pushed the http_auth branch 3 times, most recently from 72926f9 to 4fb22e6 Compare September 27, 2023 21:05
@thockin thockin changed the title WIP: Add --credential flag for multiple username/password Add --credential flag for multiple username/password Sep 27, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@thockin
Add --credential flag to spec multiple user/pass
08bb11c 
* New flag is a JSON-encoded struct.
* Add test case for multiple HTTP passwd.
@thockin thockin merged commit 162e543 into kubernetes:master Oct 8, 2023
3 checks passed
@Porkepix Porkepix mentioned this pull request Oct 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-yu nan-yu Awaiting requested review from nan-yu

@stp-ip stp-ip Awaiting requested review from stp-ip

Assignees

@stp-ip stp-ip

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

submodule specific credentials TODO: need e2e tests for various auth modes
3 participants
@thockin @k8s-ci-robot @stp-ip