-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(auth): Fix ssh authentication #868
Conversation
|
Welcome @yyvess! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG! Thanks. I'll craft an e2e test. How embarrassing.
Oof, I need a CLA signed in order to merge this. Otherwise I can recreate it along with the e2e test (if you can't sign CLA). /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, yyvess The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Yves Galante <yyvess@gmail.com>
@thockin sign CLA |
/lgtm |
Ssh authentification
Fix ssh authentification break by d5c61f7
User must not be extracted from ssh as ssh://git@github.com/kubernetes/git-sync.git