Helpers removed #2576
Helpers removed #2576
Conversation
* Currently TestSyncPod depends on the order of execution in test cases, where one test case create pod and the remaining ones update based on it. * Split each test case such that they are using different pods and thus independent of each other.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 08volt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-rebase
|
Hi @08volt. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XL
* Currently TestSyncPod depends on the order of execution in test cases, where one test case create pod and the remaining ones update based on it. * Split each test case such that they are using different pods and thus independent of each other.
* Endpoint and EPS count metrics now will track number of endpoints not in default subnet, and they are skipped from endpoint calculations in normal and degraded mode.
* Generate endpoint sets and endpoint maps from CalculateEndpoints so they contain a consistent set of endpoints. * This also makes the test easier to maintain because we don't need to hard-code got/expected endpoints.
* Rename DupCount from CalculateEndpoints to endpointsExcludedInCalculation, since we need to take endpoints from non-default subnet into account as well. * We don't need to track these counts separately outside of CalculateEndpoints() since we only need them in ValidateEndpoints() to understand the total number of endpoint we excluded during calculations. The actual numbers only matter when we emit metrics, which happends within CalculateEndpoints() in toZoneNetworkEndpointMap().
Removed helper import from: l4lb loadbalancers healthchecksl4 neg/controller.go utils/patch/patch.go Replaced import with private functions Signed-off-by: Enrico <evoltan@google.com>
08volt
force-pushed
the
helpers-removed-v3
branch
from
f63bb08
to
443db2a
Compare
k8s-ci-robot
added
size/XXL
issue #1902
Removed helper dependencies from the cloud-provider
Originally posted by Antonio Ojea in #1896 (comment)