Remove unnecessary interfaces in pkg/backends #2730
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TortillaZHawaii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @TortillaZHawaii. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
|
/lint |
There was a problem hiding this comment.
@TortillaZHawaii: 6 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
|
/lint |
There was a problem hiding this comment.
@TortillaZHawaii: 0 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
I does make the code follow go patterns a bit more, I'm adding Gaurav as well since this touches NEG pieces as well /assign @gauravkghildiyal |
As per Go Wiki interfaces should generally belong in the package that uses values of the interface type, not the package that implements these values. In this case there is no real added value of using interfaces instead of concrete types. We can safely remove them and get rid of boilerplate.