Skip to content

Commit

Permalink
Merge pull request #177 from aledbf/fix-rlimit-issues
Browse files Browse the repository at this point in the history
Refactoring sysctlFSFileMax helper
  • Loading branch information
aledbf authored Jan 26, 2017
2 parents b134472 + ec67f83 commit 92ddc6c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions controllers/nginx/pkg/cmd/controller/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"io/ioutil"
"os"
"os/exec"
"syscall"

"k8s.io/kubernetes/pkg/util/sysctl"

Expand All @@ -42,14 +43,14 @@ func sysctlSomaxconn() int {
// sysctlFSFileMax returns the value of fs.file-max, i.e.
// maximum number of open file descriptors
func sysctlFSFileMax() int {
maxConns, err := sysctl.New().GetSysctl("fs/file-max")
var rLimit syscall.Rlimit
err := syscall.Getrlimit(syscall.RLIMIT_NOFILE, &rLimit)
if err != nil {
glog.Errorf("unexpected error reading system maximum number of open file descriptors (fs.file-max): %v", err)
glog.Errorf("unexpected error reading system maximum number of open file descriptors (RLIMIT_NOFILE): %v", err)
// returning 0 means don't render the value
return 0
}

return maxConns
return int(rLimit.Max)
}

func diff(b1, b2 []byte) ([]byte, error) {
Expand Down

0 comments on commit 92ddc6c

Please sign in to comment.