Merge pull request #456 from aledbf/avoid-duplicated-us

Avoid upstreams with multiple servers with the same port

core/pkg/ingress/controller/controller.go

@@ -991,6 +991,11 @@ func (ic *GenericController) getEndpoints(
 
 	upsServers := []ingress.Endpoint{}
 
+	// avoid duplicated upstream servers when the service
+	// contains multiple port definitions sharing the same
+	// targetport.
+	adus := make(map[string]bool, 0)
+
 	for _, ss := range ep.Subsets {
 		for _, epPort := range ss.Ports {
 
@@ -1031,13 +1036,18 @@ func (ic *GenericController) getEndpoints(
 			}
 
 			for _, epAddress := range ss.Addresses {
+				ep := fmt.Sprintf("%v:%v", epAddress.IP, targetPort)
+				if _, exists := adus[ep]; exists {
+					continue
+				}
 				ups := ingress.Endpoint{
 					Address:     epAddress.IP,
 					Port:        fmt.Sprintf("%v", targetPort),
 					MaxFails:    hz.MaxFails,
 					FailTimeout: hz.FailTimeout,
 				}
 				upsServers = append(upsServers, ups)
+				adus[ep] = true
 			}
 		}
 	}