Merge pull request #661 from aledbf/update-client-go

Avoid running nginx if the configuration file is empty
kubernetes · Apr 27, 2017 · e911f20 · e911f20
2 parents 25d50fa + f4147e9
commit e911f20
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/controllers/nginx/pkg/cmd/controller/nginx.go b/controllers/nginx/pkg/cmd/controller/nginx.go
@@ -334,6 +334,9 @@ func (n NGINXController) DefaultIngressClass() string {
 // testTemplate checks if the NGINX configuration inside the byte array is valid
 // running the command "nginx -t" using a temporal file.
 func (n NGINXController) testTemplate(cfg []byte) error {
+	if len(cfg) == 0 {
+		return fmt.Errorf("invalid nginx configuration (empty)")
+	}
 	tmpfile, err := ioutil.TempFile("", "nginx-cfg")
 	if err != nil {
 		return err