Admission Controller: Support Server Dry Run

[joschi36]

Is this a BUG REPORT or FEATURE REQUEST?: BUG

NGINX Ingress controller version: 0.26.1

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:18:23Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.1", GitCommit:"d647ddbd755faf07169599a625faf302ffc34458", GitTreeState:"clean", BuildDate:"2019-10-02T16:51:36Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Environment:

• Cloud provider or hardware configuration: Private Cloud
• OS (e.g. from /etc/os-release): Centos 7
• Kernel (e.g. uname -a): 3.10.0-862.14.4.el7.x86_64
• Install tools: Own Installation
• Others:

What happened:

$ kubectl apply -f ingress-api-test.yaml --server-dry-run

Error from server (BadRequest): error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{"apiVersion":"extensions/v1beta1","kind":"Ingress",REDACTED}
to:
Resource: "extensions/v1beta1, Resource=ingresses", GroupVersionKind: "extensions/v1beta1, Kind=Ingress"
Name: "kubernetes-nginx-test", Namespace: "default"
Object: &{map["apiVersion":"extensions/v1beta1" "kind":"Ingress" "metadata":map["annotations":map["kubectl.kubernetes.io/last-applied-configuration":"{"apiVersion":"extensions/v1beta1","kind":"Ingress",REDACTED}
for: "ingress-api-test.yaml": admission webhook "validate.nginx.ingress.kubernetes.io" does not support dry run

What you expected to happen:

I expected that the nginx admission controller supports server dry run

How to reproduce it (as minimally and precisely as possible):

Create, apply any Ingress object with kubectl and the flag --server-dry-run set.

Anything else we need to know:

Didn't find any Issue/PR/Documentation about Nginx Ingress Admission Controller --server-dry-run.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bitsofdave]

Was there any resolution to this? I'm also encountering the error when using kubectl diff -f <ingress_filename.yaml>.

[stephenrjohnson]

Same error, is this on the roadmap etc?

[kelvin-yue-scmp]

It would be good if the validation webhook support dry run, so kubectl diff would work for ingress!