Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE: Don't update URL Map if unchanged #117

Merged
merged 1 commit into from
Jan 10, 2017
Merged

GCE: Don't update URL Map if unchanged #117

merged 1 commit into from
Jan 10, 2017
+136 −1

Conversation

thockin
Copy link
Member

@thockin thockin commented Jan 9, 2017

Don't send URLMaps that don't have any changes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 41.228% when pulling 0950910 on thockin:dont-sync-unchanged-urlmaps into e58f510 on kubernetes:master.

@bprashanth
Copy link
Contributor

LGTM thanks!

@bprashanth bprashanth added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2017
@bprashanth bprashanth merged commit f90e9ee into kubernetes:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bprashanth bprashanth

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thockin @k8s-reviewable @coveralls @bprashanth @k8s-ci-robot