Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations: Allow commas in URLs. #11887

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Annotations: Allow commas in URLs. #11887

merged 2 commits into from
Aug 27, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #11882

/assign Gacko

@strongjz
allow comma in url query params for oauth
098ff7b 
Signed-off-by: James Strong <strong.james.e@gmail.com>
@strongjz
spelling for tests
ee7a783 
Signed-off-by: James Strong <strong.james.e@gmail.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 26, 2024
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 26, 2024
@k8s-ci-robot k8s-ci-robot requested review from Gacko and strongjz August 26, 2024 21:40
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2024
Gacko
Gacko approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Annotations: Allow commas in URLs.
/triage accepted
/kind bug
/priority backlog
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Aug 26, 2024
@k8s-ci-robot k8s-ci-robot changed the title [release-1.11] Annotations: Allow commas in URLs. Annotations: Allow commas in URLs. Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@Gacko
Copy link
Member

Gacko commented Aug 26, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 13719ac into kubernetes:release-1.11 Aug 27, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko approved these changes

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@Gacko Gacko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @Gacko @strongjz