Force reload if a secret is updated #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/XS
|
I was just about to push my fix :) Btw, is it enough? What about when a new secret is created? I'll give it a test… |
|
Coverage decreased (-0.006%) to 44.018% when pulling bca894a388c34562c77c6a473b766ff879d48921 on aledbf:force-reload into 01a1aa3 on kubernetes:master. |
|
@stibi no, I'm updating the PR |
aledbf
force-pushed
the
force-reload
branch
from
bca894a
to
d8f3a35
Compare
|
@stibi please use quay.io/aledbf/nginx-ingress-controller:0.220 Edit: I used your example as guide with 10 updates (new host), one at a time and this works |
aledbf
force-pushed
the
force-reload
branch
from
d8f3a35
to
33ce78a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1342