Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile to work in OSX. #1581

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Fix Makefile to work in OSX. #1581

merged 1 commit into from
Oct 24, 2017
+10 −4

Conversation

rnburn
Copy link
Contributor

@rnburn rnburn commented Oct 24, 2017

Updates images/nginx-slim/Makefile so that it can work on OS X. It follows the convention used here to make the sed -i command portable.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 33.452% when pulling efaff02 on rnburn:osx into 280ec72 on kubernetes:master.

@aledbf aledbf self-assigned this Oct 24, 2017
@aledbf
Copy link
Member

aledbf commented Oct 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2017
@aledbf
Copy link
Member

aledbf commented Oct 24, 2017

@rnburn thanks!

@aledbf aledbf merged commit 3aebb45 into kubernetes:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rnburn @k8s-reviewable @coveralls @aledbf @k8s-ci-robot