fix: replace deprecated methods. #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/S
|
Coverage decreased (-0.04%) to 36.097% when pulling f80c8fb95a496dff4822baa21c518fedf3170e34 on oilbeater:fix/deprecated into 76a4a00 on kubernetes:master. |
|
The coverage decrease seems not related to this pr. |
|
@oilbeater please don't use the v1beta2 package. We need compatibility with 1.5 and 1.6 |
oilbeater
force-pushed
the
fix/deprecated
branch
from
f80c8fb to
a3136aa
Compare
k8s-ci-robot
added
size/XS
|
remove v1beta2 @aledbf |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@oilbeater thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecate method client.Extensions()