-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating prometheus metrics names according to naming best practices #1910
updating prometheus metrics names according to naming best practices #1910
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@noqcks thank you for doing this |
@noqcks please sign the CLA |
Just signed CLA. Commenting to update. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, noqcks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@noqcks thanks! |
Only counters should have _total suffixes, not gauges. Also keep in mind that changing these metrics might break alerts and dashboards, so these changes should be kept to a minimum. @brancz: Would it be possible to have a tag or something for "includes metrics" that could be added to PRs that should get reviewed by someone with prometheus experience? |
As this repo is under the Kubernetes org, we can simply use @kubernetes/sig-instrumentation-pr-reviews to tag the team that is aware of changes that involve instrumentation. Please do encourage anyone working on instrumentation related things to tag those. Otherwise what @discordianfish said regarding counter/gauge naming is correct, and we should oblige to it. |
@discordianfish @brancz can you send a PR to fix counter/gauge naming issue? |
What this PR does / why we need it: This fixes #1509. We want to be following best practices! https://prometheus.io/docs/practices/naming/
Which issue(s) this PR fixes:
Fixes #1509
Special notes for your reviewer:
Release note: