Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The maximum number of open file descriptors should be maxOpenFiles. #2031

Merged
merged 1 commit into from
Feb 3, 2018
Merged

The maximum number of open file descriptors should be maxOpenFiles. #2031

merged 1 commit into from
Feb 3, 2018

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Feb 3, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

/cc @aledbf

@k8s-ci-robot k8s-ci-robot requested a review from aledbf February 3, 2018 04:29
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.802% when pulling 2bae12c on gyliu513:log-maxOpenFiles into 42076e8 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Feb 3, 2018

/approve

@aledbf aledbf merged commit e34afc0 into kubernetes:master Feb 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, gyliu513

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2018
@aledbf
Copy link
Member

aledbf commented Feb 3, 2018

@gyliu513 thanks!

@gyliu513 gyliu513 deleted the log-maxOpenFiles branch February 4, 2018 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants