Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing lua bindata change #2208

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Add missing lua bindata change #2208

merged 1 commit into from
Mar 19, 2018

Conversation

oilbeater
Copy link
Contributor

What this PR does / why we need it:
add changes in #2205 to bindata and reformat bindata file to the format that go-bindata generated.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2018
@codecov-io
Copy link

codecov-io commented Mar 19, 2018 •
edited
Loading

Codecov Report

Merging #2208 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2208   +/-   ##
=======================================
  Coverage   36.98%   36.98%           
=======================================
  Files          70       70           
  Lines        4978     4978           
=======================================
  Hits         1841     1841           
  Misses       2857     2857           
  Partials      280      280
Impacted Files Coverage Δ
internal/file/bindata.go 51.8% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4caa13...a0dfac4. Read the comment docs.

@halfcrazy
Copy link
Contributor

halfcrazy commented Mar 19, 2018 •
edited
Loading

How about adding a lint to bindata file? Make sure internal/file/bindata.go has the same hash as code-generator generated. In case someone forgotten to update bindata file.

@oilbeater
Copy link
Contributor Author

@halfcrazy good point, I will add a verify script

@oilbeater
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2018
@oilbeater oilbeater force-pushed the fix/bindata branch 4 times, most recently from c99df4b to a0dfac4 Compare March 19, 2018 11:53
@oilbeater
Add bindata verify check and fix missing bindata changes
a0dfac4 
Add script to verify if bindata is up to date.
Add changes in kubernetes#2205 to bindata and reformat bindata file to the format that go-bindata generated.
@oilbeater
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2018
@aledbf
Copy link
Member

aledbf commented Mar 19, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Mar 19, 2018

@oilbeater thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, oilbeater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2018
@aledbf aledbf merged commit 28e6f54 into kubernetes:master Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oilbeater @codecov-io @halfcrazy @aledbf @k8s-ci-robot