Add proxy-add-original-uri-header config flag #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bashofmann
force-pushed
the
master
branch
2 times, most recently
from
b0ff7a7 to
32f6a4c
Compare
k8s-ci-robot
added
size/M
This makes it configurable if a location adds an X-Original-Uri header to the backend request. Default is "true", the current behaviour.
Codecov Report
@@ Coverage Diff @@
## master #2353 +/- ##
==========================================
- Coverage 39.23% 39.11% -0.13%
==========================================
Files 73 73
Lines 5202 5203 +1
==========================================
- Hits 2041 2035 -6
- Misses 2872 2878 +6
- Partials 289 290 +1
Continue to review full report at Codecov.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
k8s-ci-robot
added
the
approved
|
@bashofmann thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, bashofmann The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This makes it configurable if a location adds an X-Original-Uri header to the backend request. Default is "true", the current behaviour.
Our use case, we have some internal services where the URL can be quite long, though still quite below nginx's large_client_header_buffers default limit. But by automatically adding the request URI as an additional header on the backend proxy request, a similar request header size limit from the backend web server, e.g. Jetty or another nginx, is exceeded.