Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Getting the Code section to Quick Start #2457

Merged
merged 1 commit into from
May 1, 2018

Conversation

andrewloux
Copy link
Contributor

What this PR does / why we need it:

  • Want to keep dropping the barrier to developing on ingress-nginx, after having seen multiple colleagues attempt to figure it out.
  • That the code has to be checked out under the k8s.io directory is not super intuitive, making it explicit here would be beneficial imho.

Special notes for your reviewer:
cc @aledbf

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 1, 2018
@codecov-io
Copy link

Codecov Report

Merging #2457 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2457      +/-   ##
==========================================
+ Coverage   41.61%   41.67%   +0.05%     
==========================================
  Files          74       74              
  Lines        5291     5291              
==========================================
+ Hits         2202     2205       +3     
+ Misses       2792     2790       -2     
+ Partials      297      296       -1
Impacted Files Coverage Δ
cmd/nginx/main.go 23.44% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278c055...07bbcae. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented May 1, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2018
@aledbf
Copy link
Member

aledbf commented May 1, 2018

@andrewlouis93 thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, andrewlouis93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3630084 into kubernetes:master May 1, 2018
@andrewloux andrewloux deleted the update-quick-start branch May 1, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants