Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Correct ssl-passthrough annotation description. #2540

Merged
merged 1 commit into from
May 18, 2018
Merged

DOCS: Correct ssl-passthrough annotation description. #2540

merged 1 commit into from
May 18, 2018

Conversation

r7vme
Copy link

@r7vme r7vme commented May 18, 2018

What this PR does / why we need it:

Fixes incorrect description for nginx.ingress.kubernetes.io/ssl-passthrough annotation that was introduced by my other change.

User actually needs flag --enable-ssl-passthrough anyway if he wants to use ssl passthru. In my initial change i incorrectly assumed (and missed while testing) that only thing TCPProxy does is PROXY protocol header. Now i see that it's also does SNI. This means --enable-ssl-passthrough always required, despite PROXY protocol in load balancer.

I also created feature request to do SNI by nginx and not by ingress-controller.

My initial issue was that Go routine (with TCPProxy) crashed silently on all replicas.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): none

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2018
@aledbf
Copy link
Member

aledbf commented May 18, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2018
@aledbf
Copy link
Member

aledbf commented May 18, 2018

@r7vme thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, r7vme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2018
@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #2540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2540   +/-   ##
=======================================
  Coverage   40.74%   40.74%           
=======================================
  Files          73       73           
  Lines        5021     5021           
=======================================
  Hits         2046     2046           
  Misses       2701     2701           
  Partials      274      274

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92f5f8...d004fca. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit b7640cc into kubernetes:master May 18, 2018
@r7vme r7vme deleted the docs-fixsslpasshtru-description branch May 18, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants