DOCS: Correct ssl-passthrough annotation description. #2540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes incorrect description for
nginx.ingress.kubernetes.io/ssl-passthrough
annotation that was introduced by my other change.User actually needs flag
--enable-ssl-passthrough
anyway if he wants to use ssl passthru. In my initial change i incorrectly assumed (and missed while testing) that only thing TCPProxy does is PROXY protocol header. Now i see that it's also does SNI. This means--enable-ssl-passthrough
always required, despite PROXY protocol in load balancer.I also created feature request to do SNI by nginx and not by ingress-controller.
My initial issue was that Go routine (with TCPProxy) crashed silently on all replicas.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): noneSpecial notes for your reviewer: